Conversation
TurboMaxe
commented
Apr 19, 2026
TurboMaxe
commented
- updated to kotlin dsl for gradle (better tooling)
- used version catalog (idk if it works though)
- minor optimizations in some of the files
- organized listeners better using SRP principle in mind
UplandJacob
left a comment
UplandJacob
left a comment
There was a problem hiding this comment.
Can you also use tabs on all new files you made? I'm trying to normalize using tabs on all of our things.
Looks good, though!
|
I think I've fixed all(?) of the issues, please notify me if any issue arises |
UplandJacob
left a comment
UplandJacob
left a comment
There was a problem hiding this comment.
Again, can you please use tabs on all new files and the on part in the base Netty injector?
| ObjectMapper mapper = new ObjectMapper(); | ||
|
|
||
| TypeReference<Map<String, String>> typeRef = new TypeReference<Map<String, String>>() {}; | ||
| TypeReference<Map<String, String>> typeRef = new TypeReference<>() { |
There was a problem hiding this comment.
Elsewhere, you collapsed empty blocks into a single line. Why did you expand this one?
There was a problem hiding this comment.
How did these get added again? Did my gitignore not work or do you need to remove them from tracking?
UplandJacob
left a comment
UplandJacob
left a comment
There was a problem hiding this comment.
I can't merge this until the tab issues are resolved
|
turbo just add the tabs 🥀 |
3 participants
