Game page#5
Open
Martin4TheWin wants to merge 2 commits into
Open
Conversation
dusan-turajlic
approved these changes
Apr 9, 2022
Member
dusan-turajlic
left a comment
dusan-turajlic
left a comment
There was a problem hiding this comment.
Looks good over all. Left some comments make sure to resolve them before merging
| const params = useParams(); | ||
| const [gameName, setGameName] = useState(params.gameName); | ||
| const [leagues, setLeagues] = useState([]); | ||
| const [resize, setResize] = useState(window.innerWidth); |
Member
There was a problem hiding this comment.
We could make a hook out of this. It's a bit hard to figure out why this is needed just from reading the code. So I think maybe moving it into a hook would make it a bit easier to understand. Something like useWindowChange
dusan-turajlic
force-pushed
the
GamePage
branch
from
f45a4cb to
19dce3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes to the Gamepage