Accept either a w coordinate component or an RGB color for vertices#78
Open
SwishSwushPow wants to merge 1 commit into
Open
Accept either a w coordinate component or an RGB color for vertices#78SwishSwushPow wants to merge 1 commit into
SwishSwushPow wants to merge 1 commit into
Conversation
Also added two new tests for these cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where it was not possible to parse obj files that provide a w-component with their vertex coordinates. Vertices can now come with a w-component OR RGB colors. I went with this route because of the information that can be found on the Wavefront .obj Wikipedia page.
Also added new tests for these cases.