Make it more palatable for ECS environments#29
Open
vagmi wants to merge 2 commits into
Open
Conversation
…g group. Helpful for ECS setups
vagmi
changed the title
Owner
|
This is great! Apologizes, I've been busy and haven't gotten a chance to look at this yet. I'll try and review the code soon. Thanks for contributing. |
TylerBrock
reviewed
Sep 22, 2019
| } | ||
| return !lastPage | ||
| } | ||
| fmt.Printf("starting to tail logs from %d streams ...\n", len(input.LogStreamNames)) |
Owner
There was a problem hiding this comment.
Would you mind removing this bit? As part of the design I like there to be no other output than data or errors (this helps with things downstream if you pipe the output of saw into other programs)
tony84727
reviewed
Mar 18, 2021
Comment on lines
+103
to
+106
| if lastPage || len(streams) >= 100 { | ||
| return false | ||
| } | ||
| return true |
There was a problem hiding this comment.
We might return the bool directly here.
Maybe:
return !lastPage && len(streams) < 100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECS creates log stream per container and the current watch method takes about 2 minutes in my environment to get log streams. Since ECS creates log group per task, I added a
--recentflag to find streams based onEventTime.