Skip to content

make types dir inside src folder & clean some misunderstood commas#14

Open
dorlevy1 wants to merge 4 commits into
Tynopia:mainfrom
dorlevy1:make-types-dir
Open

make types dir inside src folder & clean some misunderstood commas#14
dorlevy1 wants to merge 4 commits into
Tynopia:mainfrom
dorlevy1:make-types-dir

Conversation

@dorlevy1

Copy link
Copy Markdown

Hey,
I added a folder for managing the types to make the code more organized.
Let me know if this is needed, and if so, I'll continue organizing the rest accordingly!

@dorlevy1

Copy link
Copy Markdown
Author

and i also added to the gitignore the .idea folder from the webstorm ide

@dorlevy1

Copy link
Copy Markdown
Author

if you indeed want this

###please do not merge the pull###

i also need the add the babel-plugin-module-resolver --save to package.json
and continue to make all the types

@Tynopia

Tynopia commented Nov 10, 2024

Copy link
Copy Markdown
Owner

Hey, thanks for your PR!
The code is now split across multiple files. When building, though, are the types being bundled back into a single file like index.d.ts?

@dorlevy1

dorlevy1 commented Nov 14, 2024

Copy link
Copy Markdown
Author

Yes, absolutely. If the types don’t change frequently, we can always bundle them back into index.d.ts using Babel or Webpack (and I believe Babel alone can handle this as well).

Please let me know if you want me to proceed with this or hold off for now.

-- update --
** just tested it with a build, and it does indeed bundle everything back into the index.d.ts file! **

@dorlevy1

Copy link
Copy Markdown
Author

image

@dorlevy1

Copy link
Copy Markdown
Author

@Tynopia Done for the types

@dorlevy1

dorlevy1 commented Nov 17, 2024

Copy link
Copy Markdown
Author

also fixed the lint tests , as i know , we dont need the package-lock.json no?
or am i wrong and i will add it again

@dorlevy1

Copy link
Copy Markdown
Author

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants