-
-
Notifications
You must be signed in to change notification settings - Fork 675
fix: Suggestion menu overflow issue #2363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matthewlipski
wants to merge
5
commits into
main
Choose a base branch
from
suggestion-menu-overflow-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nperez0111
reviewed
Jan 15, 2026
nperez0111
reviewed
Jan 15, 2026
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
Contributor
|
Fix looks like it works to me! |
Collaborator
Collaborator
Author
|
I added a max height of 600px - I think for this PR though, an overall UX fix-up is out of scope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Summary
This PR fixes an issue when on initial show, the suggestion menu would not correctly flip vertically if there was no space, and would only flip once the items updated.
This would happen because the
GenericPopoverresponsible for positioning and sizing the suggestion menu would do so based on its initial size. However, the menu fetches and renders its items async, so its initial size is far smaller than when it has all of its items.To fix this, the
GenericPopover's position is re-calculated when the suggestion menu items are updated.Rationale
The suggestion menu issue is pretty annoying for users and causes bad UX.
Changes
GenericPopoverUpdateContextwhich contains a function to update the position of the nearestGenericPopover.SuggestionMenuWrapperupdate ancestorGenericPopoverposition when after items are updated.autoPlacementmiddleware toflip(functions same as before, butautoPlacementwas inconsistent after this change).SuggestionMenuController.Impact
N/A
Testing
N/A
Screenshots/Video
N/A
Checklist
Additional Notes