Add per-language lexers to eliminate cross-language keyword pollution#131
Draft
cdietrich wants to merge 1 commit into
Draft
Add per-language lexers to eliminate cross-language keyword pollution#131cdietrich wants to merge 1 commit into
cdietrich wants to merge 1 commit into
Conversation
When a grammar has multiple entry rules (multi-language mode), each entry rule now gets its own NewLexerFor<i>() factory that includes only the keywords reachable from that entry point via BFS over rule calls. A generated documentParser struct (language-aware) selects the right per-language lexer based on LanguageSelector.Select(uri) before tokenising, preventing keywords from one sub-language shadowing identifiers in another. Changes: - internal/generator/reachability.go: KeywordsReachableFrom BFS traversal - internal/generator/lexer_generator.go: GenerateLexer emits NewLexerFor<i>() - internal/generator/services_generator.go: GenerateServices emits language-aware DocumentParser and uses service.Override to replace the workspace default - cmd/build.go: pass entryRules to GenerateLexer and GenerateServices Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R7GR5jLbxDCbKdhASefCMH
cdietrich
marked this pull request as draft
July 24, 2026 07:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a grammar has multiple entry rules (multi-language mode), each entry rule now gets its own NewLexerFor() factory that includes only the keywords reachable from that entry point via BFS over rule calls.
A generated documentParser struct (language-aware) selects the right per-language lexer based on LanguageSelector.Select(uri) before tokenising, preventing keywords from one sub-language shadowing identifiers in another.
Changes:
Claude-Session: https://claude.ai/code/session_01R7GR5jLbxDCbKdhASefCMH