Reduce AST memory allocations#133
Open
msujew wants to merge 1 commit into
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: e25375f | Previous: d803417 | Ratio |
|---|---|---|---|
BenchmarkWorkspaceCycle (typefox.dev/fastbelt/examples/statemachine) - MB/s |
14.62 MB/s |
5.21 MB/s |
2.81 |
BenchmarkParser (typefox.dev/fastbelt/examples/statemachine) - MB/s |
67.79 MB/s |
37.68 MB/s |
1.80 |
BenchmarkLexerAndParser (typefox.dev/fastbelt/examples/statemachine) - MB/s |
37.32 MB/s |
23.82 MB/s |
1.57 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser currently allocates a lot of empty arrays that aren't really necessary. For most purposes,
niland[](empty) slices are essentially the same. This change removes all of the array initialization code, which reduces retained memory, reduces the amount of intermediate allocated memory, and improves parsing performance.Adds a benchmark for the arithmetics language, which is affected by this change more than the statemachine language.