Skip to content

Introduce Worker Label type definition for extended and classic#1051

Merged
kaisalmen merged 2 commits into
mainfrom
kaisalmen/issue-1038
Jul 16, 2026
Merged

Introduce Worker Label type definition for extended and classic#1051
kaisalmen merged 2 commits into
mainfrom
kaisalmen/issue-1038

Conversation

@kaisalmen

@kaisalmen kaisalmen commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Upside: Clearer what are allowed worker names.
Downside: Needs to be maintained, but I think it's ok.

Fixes #1038

@kaisalmen
kaisalmen requested a review from CGNonofr as a code owner July 9, 2026 15:09
@kaisalmen
kaisalmen force-pushed the kaisalmen/issue-1038 branch from 1c8e8dd to 0ec9824 Compare July 13, 2026 15:18
@kaisalmen

kaisalmen commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator Author

@CGNonofr are you ok with these changes?

@kaisalmen
kaisalmen force-pushed the kaisalmen/issue-1038 branch from 0ec9824 to ef10b70 Compare July 13, 2026 15:37
CGNonofr
CGNonofr reviewed Jul 15, 2026
View reviewed changes

@CGNonofr CGNonofr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about doing that on the monaco-vscode-api side? 🤔

Comment thread packages/client/src/worker/index.ts
@kaisalmen

kaisalmen commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

What about doing that on the monaco-vscode-api side? 🤔

Should we move the type definitions to monaco-vscode-api?

@CGNonofr

CGNonofr commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

What about doing that on the monaco-vscode-api side? 🤔

Should we move the type definitions to monaco-vscode-api?

It probably makes more sense 🤔

@kaisalmen

kaisalmen commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator Author

@CGNonofr what about we merge this first and then open a new PR in mva. And drop the definitions again with the new release. That should be straight-forward.

@CGNonofr
CGNonofr self-requested a review July 16, 2026 09:08
@CGNonofr

CGNonofr commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

@CGNonofr what about we merge this first and then open a new PR in mva. And drop the definitions again with the new release. That should be straight-forward.

It looks more complicated to me but feel free to do it as you wish :)

@kaisalmen
kaisalmen merged commit e6d742e into main Jul 16, 2026
1 check passed
@kaisalmen
kaisalmen deleted the kaisalmen/issue-1038 branch July 16, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CGNonofr CGNonofr CGNonofr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

workerLoaders should use typed worker labels instead of string

2 participants

@kaisalmen @CGNonofr