Fix to HSI Event Queue following introduction of clinic eligibility attribute#1866
Open
marghe-molaro wants to merge 1 commit into
Open
Fix to HSI Event Queue following introduction of clinic eligibility attribute#1866marghe-molaro wants to merge 1 commit into
marghe-molaro wants to merge 1 commit into
Conversation
…c eligibility attribute. Add clinic info when logging HSI Events in mode 1
Collaborator
Author
|
@tamuri, failing tests are passing locally, is there a way to resubmit them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clinics PR introduced error in order of attributes of
HSIEventQueueItem, ordering events by clinic types first. This meant that_get_events_due_todayerroneously exited theHSI_EVENT_QUEUEat the first not-due event for the first clinic type encountered, missing all events due on the day for other clinic types. This PR fixes this, and additionally ensures clinic type is logged when logging HSI events ran in mode 1.Notice that this bug should not have impacted master's default configuration, where only one clinic type is considered.