Release v0.3.2 — relocate WORKSHOP switcher to the institutional band#7
Merged
Conversation
Relocate the cross-tool switcher out of the plum WORKSHOP band into the white institutional band as the first nav item, so its dropdown opens at the top of the page with nothing below to clip it. The trigger reads "Workshop" and is styled like the lab-nav links; the dropdown panel keeps the dark current-tool banner over the switch-to list. The mobile sheet gains a switch-tool section since the institutional band collapses there on narrow screens. Also adopt the US "Paleography" spelling and the /paleography href in DEFAULT_TOOLS and the docs. Bump to 0.3.2.
There was a problem hiding this comment.
Pull request overview
Relocates the cross-tool WORKSHOP switcher from the deep-plum workshop band to the white institutional band to prevent dropdown clipping, and updates Calamus naming/URLs to the US “Paleography” spelling across the kit surface.
Changes:
- Move
ToolSwitcherintoInstitutionalBand(first nav item) and remove it fromWorkshopBand. - Add a “switch tool” section to the mobile sheet to preserve cross-tool switching on small screens.
- Update default tool registry + docs/tests to “Paleography” and bump package version to
0.3.2.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/kit/AmplHeader.test.ts | Updates header rendering expectations for the relocated switcher and “Paleography” naming. |
| package.json | Bumps package version to 0.3.2. |
| kit/ui/ampl-header/WorkshopBand.tsx | Removes the tool switcher from the plum band; leaves contextual nav + locale/account cluster. |
| kit/ui/ampl-header/types.ts | Updates tool display-name documentation example spelling. |
| kit/ui/ampl-header/ToolSwitcher.tsx | Restyles switcher trigger for institutional band sizing and adjusts popover positioning/z-index. |
| kit/ui/ampl-header/tools.ts | Updates DEFAULT_TOOLS to “Paleography” and /paleography href. |
| kit/ui/ampl-header/MobileSheet.tsx | Adds “current tool / switch to” section for mobile, and separates sections with borders. |
| kit/ui/ampl-header/InstitutionalBand.tsx | Adds ToolSwitcher as first nav item and widens nav container sizing. |
| kit/ui/ampl-header/AmplHeader.tsx | Rewires composition: switcher props now passed to InstitutionalBand and mobile sheet. |
| kit/README.md | Updates examples to “Paleography” and /paleography. |
| kit/auth/index.ts | Updates auth helper examples to use /paleography paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
24
to
28
| account: { name: "Juan Cobo", handle: "juan", avatarUrl: null, signOutHref: "/auth/logout", returnTo: "/palaeography" }, | ||
| }); | ||
| expect(html).toContain("Palaeography"); | ||
| expect(html).toContain("Paleography"); | ||
| expect(html).toContain('method="post"'); | ||
| expect(html).toContain('action="/auth/logout?return_to=%2Fpalaeography"'); |
| /** Internal tool id — drives the switcher "current" highlight. */ | ||
| tool: ToolId; | ||
| /** Public display name shown in the WORKSHOP band (e.g. "Palaeography"). */ | ||
| /** Public display name shown in the WORKSHOP band (e.g. "Paleography"). */ |
Comment on lines
118
to
122
| // Compact signed-in header (standard in-app use) | ||
| <AmplHeader | ||
| tool="calamus" | ||
| toolName="Palaeography" | ||
| toolName="Paleography" | ||
| localeSwitcher={<LocaleSwitcher variant="on-dark" buildHref={buildHref} current={locale} />} |
| { | ||
| "name": "@ampl/kit", | ||
| "version": "0.3.1", | ||
| "version": "0.3.2", |
Comment on lines
+8
to
+11
| * v0.3.2: the cross-tool switcher moved from the WORKSHOP band into the | ||
| * institutional band; the mobile sheet gains a "switch tool" section. | ||
| * | ||
| * @version v0.3.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the cross-tool WORKSHOP switcher out of the plum band into the white institutional band (first nav item), so its dropdown opens at page-top and is never clipped by an in-app sticky toolbar. Trigger reads "Workshop"; the dropdown keeps the dark current-tool banner + switch-to list. The mobile sheet gains a switch-tool section.
Also adopts the US "Paleography" spelling and /paleography href in DEFAULT_TOOLS and docs.
Kit suite green (150/150), typecheck + i18n parity clean.