Skip to content

(MA-609) Voice Over Accessibility Improvements.#2318

Draft
klortiz13 wants to merge 20 commits into
experimentalfrom
MA-609-A-EventsCard-klortiz13
Draft

(MA-609) Voice Over Accessibility Improvements.#2318
klortiz13 wants to merge 20 commits into
experimentalfrom
MA-609-A-EventsCard-klortiz13

Conversation

@klortiz13

@klortiz13 klortiz13 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Made accessibility improvements according to https://its-pro.ucsd.edu/browse/MA-609

A1: Homepage Banner Voice Over (VO) fixed

TWOW.Banner.Voice.Over.webm

A2: Homepage Card Headings VO fixed

Card.Heading.VO.mp4

A3: Fixed Events Card VO for each event.

Events.card.VO.webm

A4: Fixed Events details VO

Events.Details.VO.Fixed.webm

B1: Fixed News VO
Screen_recording_20260709_151154.webm

C1: Fixed Parking Card VO

Screen_recording_20260709_153028.webm

Changelog

[General] [Add] - Added accessibility improvements.

Test Plan

Ensure the items shown above work as expected.

…onally, I added the URL so people can hear it and know the link.
@klortiz13 klortiz13 self-assigned this Jul 9, 2026
@klortiz13 klortiz13 changed the title (MA-609) Part A: Accessibility Improvements for Homepage and Events Card. (MA-609) Voice Over Accessibility Improvements. Jul 9, 2026
@github-actions

Copy link
Copy Markdown

Code Style Violations Found

  • Static Constants (UPPER_SNAKE_CASE): 10 violations
  • Very Long If Statement Conditions: 37 violations

Total Violations: 47
Total Categories Failed: 2/6

Here are the formatting rules to follow:

  • Static Constants have to use UPPER_SNAKE_CASE (e.g., MAX_RETRY_COUNT)
  • Classes have to use UpperCamelCase (e.g., UserProfile)
  • Variables/Functions have to use lowerCamelCase (e.g., userName)
  • Files/Directories have to use snake_case (e.g., user_profile.dart)
  • Imports have to use full package paths (e.g., package:app_name/path/file.dart)
  • If Conditions have to split long/complex conditions into variables for readability

Example of a long if condition violation:

if (userDataProvider.isLoggedIn &&
    (userDataProvider.userProfileModel.classifications?.staff ?? false)) {
  // action
}
// GOOD: split condition into variables for readability
var isLoggedIn = userDataProvider.isLoggedIn;
var isStaff = userDataProvider.userProfileModel.classifications?.staff ?? false;
if (isLoggedIn && isStaff) {
  // action
}

To see more details and fix these violations:

  1. Run ./scripts/auto_check_all.sh locally.
  2. Apply the suggested corrections.
  3. Re-run the script to verify fixes.
  4. Commit your changes.

This comment will continue to appear until all violations are resolved.

@github-actions

Copy link
Copy Markdown

Code Style Violations Found

  • Very Long If Statement Conditions: 21 violations

Total Violations: 21
Total Categories Failed: 1/6

Here are the formatting rules to follow:

  • Static Constants have to use UPPER_SNAKE_CASE (e.g., MAX_RETRY_COUNT)
  • Classes have to use UpperCamelCase (e.g., UserProfile)
  • Variables/Functions have to use lowerCamelCase (e.g., userName)
  • Files/Directories have to use snake_case (e.g., user_profile.dart)
  • Imports have to use full package paths (e.g., package:app_name/path/file.dart)
  • If Conditions have to split long/complex conditions into variables for readability

Example of a long if condition violation:

if (userDataProvider.isLoggedIn &&
    (userDataProvider.userProfileModel.classifications?.staff ?? false)) {
  // action
}
// GOOD: split condition into variables for readability
var isLoggedIn = userDataProvider.isLoggedIn;
var isStaff = userDataProvider.userProfileModel.classifications?.staff ?? false;
if (isLoggedIn && isStaff) {
  // action
}

To see more details and fix these violations:

  1. Run ./scripts/auto_check_all.sh locally.
  2. Apply the suggested corrections.
  3. Re-run the script to verify fixes.
  4. Commit your changes.

This comment will continue to appear until all violations are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants