(MA-609) Voice Over Accessibility Improvements.#2318
Draft
klortiz13 wants to merge 20 commits into
Draft
Conversation
…onally, I added the URL so people can hear it and know the link.
Code Style Violations Found
Total Violations: 47 Here are the formatting rules to follow:
Example of a long if condition violation:if (userDataProvider.isLoggedIn &&
(userDataProvider.userProfileModel.classifications?.staff ?? false)) {
// action
}// GOOD: split condition into variables for readability
var isLoggedIn = userDataProvider.isLoggedIn;
var isStaff = userDataProvider.userProfileModel.classifications?.staff ?? false;
if (isLoggedIn && isStaff) {
// action
}To see more details and fix these violations:
This comment will continue to appear until all violations are resolved. |
Code Style Violations Found
Total Violations: 21 Here are the formatting rules to follow:
Example of a long if condition violation:if (userDataProvider.isLoggedIn &&
(userDataProvider.userProfileModel.classifications?.staff ?? false)) {
// action
}// GOOD: split condition into variables for readability
var isLoggedIn = userDataProvider.isLoggedIn;
var isStaff = userDataProvider.userProfileModel.classifications?.staff ?? false;
if (isLoggedIn && isStaff) {
// action
}To see more details and fix these violations:
This comment will continue to appear until all violations are resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Made accessibility improvements according to https://its-pro.ucsd.edu/browse/MA-609
A1: Homepage Banner Voice Over (VO) fixed
TWOW.Banner.Voice.Over.webm
A2: Homepage Card Headings VO fixed
Card.Heading.VO.mp4
A3: Fixed Events Card VO for each event.
Events.card.VO.webm
A4: Fixed Events details VO
Events.Details.VO.Fixed.webm
B1: Fixed News VO
Screen_recording_20260709_151154.webm
C1: Fixed Parking Card VO
Screen_recording_20260709_153028.webm
Changelog
[General] [Add] - Added accessibility improvements.
Test Plan
Ensure the items shown above work as expected.