Skip to content

Tel 325 update map to the new track#285

Open
promatty wants to merge 4 commits intomainfrom
TEL-325-Update-Map-to-the-new-track
Open

Tel 325 update map to the new track#285
promatty wants to merge 4 commits intomainfrom
TEL-325-Update-Map-to-the-new-track

Conversation

@promatty
Copy link
Member

@promatty promatty commented Feb 28, 2026

Summary by CodeRabbit

  • Updates
    • The map now defaults to Brainerd International Raceway (3.1 mi), replacing the previous demo track.
    • Demo marker data, preview info, and track visualization reflect the Brainerd layout.
    • Users opening the map will see Brainerd International Raceway displayed by default.

@promatty promatty requested a review from a team as a code owner February 28, 2026 21:21
@vercel
Copy link

vercel bot commented Feb 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
helios-telemetry Ready Ready Preview, Comment Feb 28, 2026 9:42pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 28, 2026

Warning

Rate limit exceeded

@promatty has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 59 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between d45e39c and c26ed01.

📒 Files selected for processing (2)
  • packages/client/src/components/containers/MapContainer.tsx
  • packages/client/src/components/molecules/MapMolecules/Map.tsx
📝 Walkthrough

Walkthrough

Switches the default demo track from Grand Full Course to Brainerd International Raceway (3.1mi) by adding Brainerd GeoJSON and hydrated marker data, updating GEO_DATA, TRACK_LIST, and default dataPoints/imports used by the map components.

Changes

Cohort / File(s) Summary
Map Setup & Track Dataset
packages/client/src/components/molecules/MapMolecules/MapSetup.ts
Adds BRAINERD_INTERNATIONAL_RACEWAY_TRACK_GEO_JSON, raceTrackGeoJSON_BRAINERD_INTERNATIONAL_RACEWAY_TRACK, Hydrated_Brainerd_International_Raceway_Track; constructs NEW_TRACK from Brainerd GeoJSON; updates GEO_DATA and TRACK_LIST to use Brainerd track; removes/comments prior track exports and demo.
Map Initialization & Imports
packages/client/src/components/molecules/MapMolecules/Map.tsx
Replaces import and initial dataPoints default from Hydrated_Grand_Full_course to Hydrated_Brainerd_International_Raceway_Track.
Map Container Track Reference
packages/client/src/components/containers/MapContainer.tsx
Swaps GEO_DATA mapping key from raceTrackGeoJSON_GRAND_FULL_COURSE to raceTrackGeoJSON_BRAINERD_INTERNATIONAL_RACEWAY_TRACK (adds comment about prior 2025 track).

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • React compiler #278: Modifies Map.tsx and related track/source types—closely related to these map track/data source changes.

Poem

🐰 I hopped from Grand to Brainerd's bend,
Lines of GeoJSON now extend,
Hydrated markers leap in cheer,
New track, new path — the finish near! 🏁

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the map to use a new track (Brainerd International Raceway) instead of the Grand Full Course.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch TEL-325-Update-Map-to-the-new-track

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/client/src/components/molecules/MapMolecules/MapSetup.ts`:
- Around line 1331-1333: The NEW_TRACK array created from
BRAINERD_INTERNATIONAL_RACEWAY_TRACK_GEO_JSON.features currently leaves the
LineString open (first and last coordinates differ), causing a render gap and
lap-reset jump; update the logic that maps features to coordinates (the
NEW_TRACK creation) to ensure each coordinates array is closed by checking if
the first coordinate equals the last and, if not, appending the first coordinate
to the end; apply the same fix to the duplicate mapping at the other occurrence
(the block around the second mapping you noted) so both track arrays are
explicitly closed before being used for rendering.

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 77523a9 and 52fc188.

📒 Files selected for processing (3)
  • packages/client/src/components/containers/MapContainer.tsx
  • packages/client/src/components/molecules/MapMolecules/Map.tsx
  • packages/client/src/components/molecules/MapMolecules/MapSetup.ts

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
packages/client/src/components/molecules/MapMolecules/MapSetup.ts (1)

1496-1508: Trim large commented legacy blocks to keep MapSetup.ts maintainable.

Keeping full deprecated track objects inline as comments makes this module harder to navigate. Prefer removing these blocks and keeping history in git (or moving old tracks to a separate archival fixture/doc file).

♻️ Proposed cleanup
-  // 2025 Summer track - kept for reference
-  // {
-  //   ...
-  // },
+  // Legacy track variants are available in git history / track fixtures.
...
-// Previous demo track markers - kept for reference
-// export const Hydrated_Grand_Full_course: PacketMarkerData[] =
-//   ...
+// Legacy demo marker set removed; recoverable from git history if needed.

Also applies to: 1521-1546, 1575-1589

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@packages/client/src/components/molecules/MapMolecules/MapSetup.ts` around
lines 1496 - 1508, Remove the large commented legacy track objects in
MapSetup.ts (e.g., the commented block containing layerProps, sourceProps with
raceTrackGeoJSON_CORVETTE_RACE_LOOP and trackName "Corvette Race Loop"); either
delete them or move them into a dedicated archival fixture/doc (e.g.,
old-tracks.ts or fixtures/archive) and leave a short one-line comment
referencing the archive, and apply the same cleanup to the other legacy comment
blocks that contain track objects (the other commented layer/source/trackName
groups).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@packages/client/src/components/molecules/MapMolecules/MapSetup.ts`:
- Around line 1496-1508: Remove the large commented legacy track objects in
MapSetup.ts (e.g., the commented block containing layerProps, sourceProps with
raceTrackGeoJSON_CORVETTE_RACE_LOOP and trackName "Corvette Race Loop"); either
delete them or move them into a dedicated archival fixture/doc (e.g.,
old-tracks.ts or fixtures/archive) and leave a short one-line comment
referencing the archive, and apply the same cleanup to the other legacy comment
blocks that contain track objects (the other commented layer/source/trackName
groups).

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 52fc188 and d45e39c.

📒 Files selected for processing (1)
  • packages/client/src/components/molecules/MapMolecules/MapSetup.ts

Copy link
Collaborator

@justin-phxm justin-phxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFRM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants