Skip to content

chore(ci): add explicit GITHUB_TOKEN permissions to workflows#347

Open
jdichev wants to merge 1 commit into
UI5:masterfrom
jdichev:master
Open

chore(ci): add explicit GITHUB_TOKEN permissions to workflows#347
jdichev wants to merge 1 commit into
UI5:masterfrom
jdichev:master

Conversation

@jdichev
Copy link
Copy Markdown
Contributor

@jdichev jdichev commented May 26, 2026

Prepare for the upcoming read-only default GITHUB_TOKEN enforcement by declaring minimum required permissions in all workflows.

Copilot AI review requested due to automatic review settings May 26, 2026 12:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@kineticjs kineticjs assigned kineticjs and unassigned kineticjs May 26, 2026
@kineticjs kineticjs self-requested a review May 26, 2026 13:29
@kineticjs kineticjs closed this May 26, 2026
@kineticjs kineticjs reopened this May 26, 2026
@kineticjs
Copy link
Copy Markdown
Contributor

kineticjs commented May 26, 2026

btw when i ran agent review, it suggested to add one more permission:

Issue: missing pull-requests: write on release.yml

Why:
The release workflow’s last step runs the custom bump-version action, which:

Pushes a branch (git push)
Creates a PR via gh pr create --fill
await exec.exec('git', ['push', '-u', 'origin', bump-version-${version}]);
await exec.exec('gh', ['pr', 'create', '--fill']);
gh pr create requires pull-requests: write. With only contents: write, the release and asset upload may succeed, but bump-version will fail when creating the PR.

See file @.github/actions/bump-version/index.js:28

Suggested fix for release.yml:

permissions:
  contents: write
  pull-requests: write

Prepare for the upcoming read-only default GITHUB_TOKEN enforcement
by declaring minimum required permissions in all workflows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants