feat(ui5-avatar-badge): add accessibleName property for custom tooltip#13390
Open
plamenivanov91 wants to merge 4 commits intomainfrom
Open
feat(ui5-avatar-badge): add accessibleName property for custom tooltip#13390plamenivanov91 wants to merge 4 commits intomainfrom
plamenivanov91 wants to merge 4 commits intomainfrom
Conversation
…p text The badge now supports a new accessibleName property to customize the tooltip text displayed on hover. When not provided, the badge uses a smart fallback: 1. User-provided accessibleName (highest priority) 2. Icon semantic name (e.g., "edit" -> "Edit") 3. i18n "Avatar" text from message bundle (lowest, ensures always defined) This gives developers full control over badge accessibility while maintaining sensible defaults for better user experience and accessibility. - Added public accessibleName property - Integrated i18n bundle support with @i18n decorator for fallback - Updated Icon mode from "Decorative" to "Image" to enable tooltip display - Added comprehensive Cypress tests for default, custom, and invalid icon cases - Updated documentation with accessibleName property explanation - Fixed React sample alignment by wrapping avatars in flex container - Updated HTML and React test pages with accessibility examples
Collaborator
|
🚀 Deployed on https://pr-13390--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The badge now supports a new accessibleName property to customize the tooltip text displayed on hover. When not provided, the badge uses a smart fallback:
This gives developers full control over badge accessibility while maintaining sensible defaults for better user experience and accessibility.