Skip to content

fix(ui5-step-input): adjust z-index and fix focus issues #13391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NHristov-sap merged 5 commits into from
Apr 16, 2026
+17 −8
Merged

fix(ui5-step-input): adjust z-index and fix focus issues #13391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8902a2a
fix(ui5-step-input): adjust z-index and fix focus issues
NHristov-sap Apr 15, 2026
83223c7
Merge branch 'main' into GH_stepinput_zindex
NHristov-sap Apr 16, 2026
01932b7
Merge branch 'main' into GH_stepinput_zindex
GDamyanov Apr 16, 2026
3d4cbaa
fix(ui5-step-input): fix comment
NHristov-sap Apr 16, 2026
37c07a2
Merge branch 'GH_stepinput_zindex' of https://github.com/SAP/ui5-webc…
NHristov-sap Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions packages/main/src/StepInput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ class StepInput extends UI5Element implements IFormInputElement {

_onButtonFocusOut() {
setTimeout(() => {
if (!this._inputFocused) {
if (!this._inputFocused && !this.shadowRoot!.activeElement) {
this.inputOuter.removeAttribute("focused");
Comment thread
NHristov-sap marked this conversation as resolved.
}
}, 0);
Expand All @@ -507,13 +507,11 @@ class StepInput extends UI5Element implements IFormInputElement {
}

_onMouseWheel(e: WheelEvent) {
if (this.disabled || this.readonly) {
if (this.disabled || this.readonly || !this._isFocused) {
return;
}

if (this._isFocused) {
e.preventDefault();
}
e.preventDefault();

const isScrollUp = e.deltaY < 0;
const modifier = isScrollUp ? this.step : -this.step;
Expand Down Expand Up @@ -767,15 +765,25 @@ class StepInput extends UI5Element implements IFormInputElement {
return !Number.isNaN(parsedValue) && !/, {2,}/.test(typedValue);
}

_decSpin() {
_decSpin(e: MouseEvent) {
if (this._isFocused || this._decIconDisabled) {
e.preventDefault();
}
if (!this._decIconDisabled) {
this._spinValue(false, true);
} else {
this.input.focus();
}
}

_incSpin() {
_incSpin(e: MouseEvent) {
if (this._isFocused || this._incIconDisabled) {
e.preventDefault();
}
if (!this._incIconDisabled) {
this._spinValue(true, true);
} else {
this.input.focus();
}
}

Expand Down
3 changes: 2 additions & 1 deletion packages/main/src/themes/StepInput.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
box-sizing: border-box;
height: var(--_ui5_input_height);
position: relative;
isolation: isolate;
margin: var(--_ui5_input_margin_top_bottom) 0;
min-width: var(--_ui5_step_input_min_width);
text-align: right;
Expand Down Expand Up @@ -99,7 +100,7 @@
pointer-events: none;
border-radius: var(--sapField_BorderCornerRadius);
border-style: var(--_ui5_input_error_warning_border_style);
z-index: 1;
z-index: 0;
border-width: 0px;
}

Expand Down
Loading