Skip to content

Cdd 3090 be UI updates chart data classification water mark#3142

Open
dandammann wants to merge 12 commits intomainfrom
CDD-3090-BE-UI-Updates-Chart-Data-Classification-Water-Mark
Open

Cdd 3090 be UI updates chart data classification water mark#3142
dandammann wants to merge 12 commits intomainfrom
CDD-3090-BE-UI-Updates-Chart-Data-Classification-Water-Mark

Conversation

@dandammann
Copy link
Copy Markdown
Contributor

Description

Charts that are displayed on non public dashboard pages should contain an official sensitive water mark.

When updating the charts in the API layer you are going to update the 2 charts endpoints V2 and V3

The schema should be updated so that there is an optional is_public attribute and an optional data classification in the request body.

If the chart endpoint is called with is_public marked as false then data_classification can be passed, else it defaults to “official sensitive”.

Acceptance Criteria:

Charts rendered on the frontend or created by the chart endpoint should contain an Water mark to the choose data classification water mark that match the designs.

Water mark should only be display on chart on Non public pages .


Type of change

Please select the options that are relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Tech debt item (this is focused solely on addressing any relevant technical debt)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • I have added tests at the right levels to prove my change is effective
  • [ ] I have added screenshots or screen grabs where appropriate
  • I have added docstrings in the correct style (google)

@dandammann dandammann requested a review from a team as a code owner April 20, 2026 23:32
Comment thread metrics/interfaces/charts/common/chart_output.py Outdated
Comment thread metrics/interfaces/charts/common/chart_output.py Outdated
Comment thread metrics/api/views/charts/single_category_charts.py Outdated
Comment thread metrics/api/views/charts/single_category_charts.py Outdated
Comment thread metrics/interfaces/charts/common/chart_output.py Outdated
Comment thread tests/unit/metrics/interfaces/charts/common/test_chart_output.py Outdated
Comment thread tests/unit/metrics/api/serializers/charts/test_data_classification.py Outdated
Comment thread tests/unit/metrics/interfaces/charts/common/test_chart_output.py
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants