Skip to content

#81: assign streams to fixed variables#90

Open
mo-laurenboon wants to merge 4 commits into
mainfrom
81_get_fx_streams
Open

#81: assign streams to fixed variables#90
mo-laurenboon wants to merge 4 commits into
mainfrom
81_get_fx_streams

Conversation

@mo-laurenboon

Copy link
Copy Markdown
Contributor

Closes issue #81

@mo-laurenboon

mo-laurenboon commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

NOTE: In order to make these variables available, an update will be required to source the full mappings json file rather than the condensed version originally used. This should be incorporated within #89 and special attention made to make sure key name changes between the 2 json files do not affect functionality.

EDIT: It may instead be more valuable to inject the mapping information into the condensed json file currently used. This is far less complex than changing all other references and directly copying a much larger file when not absolutely necessary.

@mo-laurenboon mo-laurenboon marked this pull request as ready for review June 18, 2026 13:58

@matthew-mizielinski matthew-mizielinski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in principle ok, but I would like the afx/ofx stream sorted

Comment on lines +308 to +311
if realm in ["ocean", "ocnBgchem", "seaIce"]:
stream = "ofx"
elif realm in ["atmos", "aerosol", "atmosChem", "land", "landIce"]:
stream = "afx"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need to confirm that this is correct; there could be some seaIce in the afx stream, but check with @mo-gill as to which way round they are

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have cross referenced with Issue 915 on CDDS (Produce BCVs) and this all seems consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants