Conversation
harim789
reviewed
May 23, 2026
Comment on lines
+31
to
+32
| // 성별 문자열을 enum으로 변환 (DTO에선 String으로 받았지만 엔티티는 enum) | ||
| private static Gender parseGender(String value) { |
There was a problem hiding this comment.
문자열 값을 Gender의 enum 형식으로 바꾸는 메서드를 따로 두신 거 정말 좋은 것 같아요! 저는 enum 값을 만들어야할 때마다 .valueOf를 반복적으로 작성하면서 일일이 enum값으로 바꿨는데, 저도 enum값을 인자로 넣을 일이 많아지면 이렇게 메서드를 따로 만들어서 해야겠네요!
harim789
reviewed
May 23, 2026
| private String address; | ||
|
|
||
| @Column(name = "email", nullable = false, length = 50) | ||
| @Column(name = "email", nullable = false, length = 50, unique = true) |
There was a problem hiding this comment.
이메일 칼럼에 unique = true을 적용하신 거 정말 좋은 것 같아요! 저는 회원가입 서비스 로직에서 memberRepository.existsByEmail(email)을 사용해 이메일 중복을 따로 검증했는데, 이메일 칼럼에 unique = true을 적용하면 회원가입 서비스 로직에서 이메일 중복 로직을 제거할 수 있어 더 간단해지겠네요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✏️ 작업 내용
#️⃣ 연관된 이슈
closes #108
💡 함께 공유하고 싶은 부분
🤔 질문
✅ 워크북 체크리스트
✅ 컨벤션 체크리스트
📌 주안점