Conversation
|
도메인형 아키텍처에 맞게 잘 만드신 것 같습니다 !! |
|
브랜치 이름은 닉네임 + 이슈번호 이런식으로 하면 될 것 같아요! 그리고 Assignee와 Reviewer를 설정해주는 게 좋아요. Store엔티티가 빠져있는 것 같아서 이 부분도 추가해주시면 좋을 듯 합니다. 이번 내용은 세팅 위주라 크게 어려울 것은 없었을거라 예상합니다. |
CokaNuri
approved these changes
Apr 13, 2026
CokaNuri
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✏️ 작업 내용
#️⃣ 연관된 이슈
closes #15
💡 함께 공유하고 싶은 부분
🤔 질문
✅ 워크북 체크리스트
✅ 컨벤션 체크리스트
📌 주안점