Skip to content

Allow sudo and auto-source setup.bash files #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NotNotQuinn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow sudo and auto-source setup.bash files #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions umrt-build-dev.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,13 @@
) > /etc/ssh/sshd_config.d/umrt.conf \
&& mkdir /run/sshd

# Automagically source the ros environment for root and user
RUN --mount=type=secret,id=DEV_USER_NAME ( \
echo 'source /opt/ros/humble/setup.bash' \
echo 'if [ -f /workspace/install/setup.bash ]; then source /workspace/install/setup.bash; fi' \
) | tee /home/"$(cat /run/secrets/DEV_USER_NAME)"/.bashrc >> /root/.bashrc

# Add user to sudo group
RUN --mount=type=secret,id=DEV_USER_NAME usermod -aG sudo "$(cat /run/secrets/DEV_USER_NAME)"

ENTRYPOINT /usr/sbin/sshd && /bin/bash

Check warning on line 40 in umrt-build-dev.Dockerfile

View workflow job for this annotation

GitHub Actions / build-umrt-build-dev / build-and-push-image

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals 

JSONArgsRecommended: JSON arguments recommended for ENTRYPOINT to prevent unintended behavior related to OS signals
More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/
Loading