Skip to content

Create CodeReview.md #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Create CodeReview.md #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CodeReview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
You did not include any comments in your test/nlp_tools_test.py file. I do not know which function is doing what very easily. I will have to read the function and try to figure out what each function is doing. Please include some comments in this file.
Same problem with nlp_tools.py. I do not know what each function is doing. You have also not organized your code in any way. The server.py, and nlp_model.py all are in the same place. Segregating them into folders would help both the reader and you in the long run.