Translations user permissions#2330
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates user-facing permission descriptions and the “remove user” confirmation text to be translatable (and consistently keyed) across English, Catalan, and Spanish.
Changes:
- Standardizes several permission-description msgids to lowercase to match the strings used in
lib/Ravada.pm. - Adds new translation entries for additional permissions and the remove-user confirmation message in
en.po,ca.po, andes.po. - Fixes punctuation in the remove-user confirmation template string.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/main/manage_user_remove.html.ep | Updates the confirmation text to match the new translation key (punctuation). |
| lib/Ravada/I18N/es.po | Adds/updates Spanish translations for permission strings and the remove-user warning. |
| lib/Ravada/I18N/en.po | Adds/updates English translation entries for the new/standardized permission strings and warning. |
| lib/Ravada/I18N/ca.po | Adds/updates Catalan translations for permission strings and the remove-user warning. |
| lib/Ravada.pm | Aligns grant description strings with the new lowercase msgids used for translation lookup. |
Comments suppressed due to low confidence (1)
lib/Ravada/I18N/es.po:2622
- The Spanish translation for "can manage all the virtual networks." says "puede gestionar todas las máquines virtuales.": it refers to machines instead of networks and also contains a typo ("máquines" -> "máquinas"). Please adjust the translation to mention virtual networks and fix the spelling.
msgid "can manage all the virtual networks."
msgstr "puede gestionar todas las máquines virtuales."
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2608
to
+2610
| msgid "can create virtual networks." | ||
| msgstr "puede crear máquinas virtuales." | ||
|
|
| msgstr "pot hibernar les seves màquines virtuals." | ||
|
|
||
| msgid "can manage all the virtual networks." | ||
| msgstr "pot gestionar totes les màquines virtuals." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added translations for user permissions and the delete user warning message to english, catalan and spanish.