GoPiGo3 Runtime: convert URML LFU frame to GoPiGo3 RFD frame in orbit() and turn_degrees()#602
Open
slowrunner wants to merge 2 commits into
Open
GoPiGo3 Runtime: convert URML LFU frame to GoPiGo3 RFD frame in orbit() and turn_degrees()#602slowrunner wants to merge 2 commits into
slowrunner wants to merge 2 commits into
Conversation
…r orbit() and turn_degrees() Per Issue URML-MARS#598 and Issue URML-MARS#591 Signed-off-by: slowrunner <slowrunner@users.noreply.github.com>
Signed-off-by: slowrunner <slowrunner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Issue #598
and Issue #591
What changed and why
gopigo3_adapter.py - the GoPiGo3 Runtime must convert the URML Left-Front-Up frame
to the GoPiGo3 Right-Front-Down frame
Calls to easygopigo3.orbit(arc,radius_cm) and .turn_degrees(angle) have negated arc and angle
Linked RFC
How it was tested
Using test_orbit_turn.urml.yaml containing:
Dry Run:
And with --execute:
Turned and orbited in a ccw direction per the URML specification
(Albeit the turn_by spin default speed is uncomfortably fast...)
Rollback plan
revert gopigo3_adapter.py
Checklist
git commit -s). SeeDCOandCONTRIBUTING.md.CHANGELOG.mdupdated.