CDA-72: OpenAPI Documentation: Added verification of requirement status for query parameters to tests#1587
Open
zack-rma wants to merge 4 commits intoUSACE:developfrom
Open
Conversation
rma-rripken
previously approved these changes
Feb 20, 2026
Collaborator
rma-rripken
left a comment
rma-rripken
left a comment
There was a problem hiding this comment.
These all look good but there are still some failing static analysis tests related to required parameters for timezone and effective-date. I assume you'll look into those in a follow-up?
zack-rma
force-pushed
the
bugfix/openapi-required-annotations
branch
from
de2abea to
e346991
Compare
rma-rripken
approved these changes
Feb 21, 2026
Collaborator
rma-rripken
left a comment
rma-rripken
left a comment
There was a problem hiding this comment.
The annotation isn't my favorite solution but its very effective from a cost/value standpoint
Contributor
Agreed, certainly can't think of anything better and it is clear to the reader (developer) what might be happening. |
MikeNeilson
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1494
Adds verification of required status for query parameters. Also checks parameter type.