CDA-86: Added test to verify office permission bug is resolved.#1601
Open
zack-rma wants to merge 5 commits intoUSACE:developfrom
Open
CDA-86: Added test to verify office permission bug is resolved.#1601zack-rma wants to merge 5 commits intoUSACE:developfrom
zack-rma wants to merge 5 commits intoUSACE:developfrom
Conversation
rma-rripken
previously approved these changes
Feb 24, 2026
MikeNeilson
requested changes
Feb 24, 2026
| .then() | ||
| .log().ifValidationFails(LogDetail.ALL,true) | ||
| .assertThat() | ||
| .statusCode(is(HttpServletResponse.SC_OK)); |
Contributor
There was a problem hiding this comment.
yesterdays CDA endpoints call made it pretty clear that just because we get a 200, doesn't mean we got any data. Several returned empty sets when we knew there was data.
Collaborator
Author
There was a problem hiding this comment.
I've updated the test to verify the response data.
Collaborator
Author
|
Looks like the tests are failing, I'll be looking into this further. |
Collaborator
Author
|
Expected results were not being included in the first response page. Added page size query parameter to the test. |
rma-rripken
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1522.
Office issue has been resolved in previous update, this PR includes a test to verify the issue no longer exists.
Message left without update as issue could not be replicated.