Remove custom arrayToAttributes and jsonPrettyPrint functions#2
Open
kennethormandy wants to merge 3 commits intoUSChamber:mainfrom
Open
Remove custom arrayToAttributes and jsonPrettyPrint functions#2kennethormandy wants to merge 3 commits intoUSChamber:mainfrom
arrayToAttributes and jsonPrettyPrint functions#2kennethormandy wants to merge 3 commits intoUSChamber:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I saw your talk at Dot All, and finally got around to checking this out. It’s an interesting approach, thanks for sharing.
I’ve made a few changes here which would have made it a bit easier for me to get it running locally:
jsonPrettyPrintin favour of built-in pretty printingarrayToAttributesin favour of built-inattr