Skip to content

[codex] Add AddNodePanel message type story#859

Draft
dbacomputer wants to merge 3 commits into
mainfrom
codex/messages-add-node-panel
Draft

[codex] Add AddNodePanel message type story#859
dbacomputer wants to merge 3 commits into
mainfrom
codex/messages-add-node-panel

Conversation

@dbacomputer

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a Storybook preview for AddNodePanel message types.
  • Shows three Document extraction states side by side: availability check failed, service not enabled, and missing license.
  • Uses the real AddNodePanel drill-in pattern so each example includes the back button, search input, centered message, and action.

UX Pattern

This story documents blocker and recovery messages inside the Add Node panel. Each state keeps the same panel shell and title area so reviewers can compare message tone, spacing, and next actions consistently.

  • Retryable availability issue: show a short message and a Try again action.
  • Tenant/service configuration issue: explain what is disabled and provide an Admin services action.
  • License/permission issue: explain the blocker and provide a Contact administrator action.

Validation

  • Ran Biome format check for AddNodePanel.stories.tsx.
  • Verified the Storybook story renders locally with three back buttons and three actions.

Copilot AI review requested due to automatic review settings June 26, 2026 18:33
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-design 🟢 Ready Preview, Logs Jun 26, 2026, 11:38:16 AM
apollo-docs 🟢 Ready Preview, Logs Jun 26, 2026, 11:38:16 AM
apollo-landing 🟢 Ready Preview, Logs Jun 26, 2026, 11:38:16 AM
apollo-vertex 🟢 Ready Preview, Logs Jun 26, 2026, 11:38:16 AM

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • 1945 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1715
ISC 89
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new Storybook coverage for canvas panel messaging/validation patterns to aid UX review, plus a small internal import-path adjustment.

Changes:

  • Adds an “Add node panel message types” Storybook story that previews three Document extraction empty-state message variants side by side.
  • Extends the NodePropertyPanel Storybook file with an “Alerts and Errors” story demonstrating tab-level counts, a summary list, and inline field validation treatment.
  • Updates HierarchicalCanvas to import BaseNode via the direct module path.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/apollo-react/src/canvas/components/NodePropertyPanel/NodePropertyPanel.stories.tsx Adds an “Alerts and Errors” story and supporting UI helpers to showcase validation patterns.
packages/apollo-react/src/canvas/components/HierarchicalCanvas/HierarchicalCanvas.tsx Adjusts BaseNode import path to a direct module import.
packages/apollo-react/src/canvas/components/AddNodePanel/AddNodePanel.stories.tsx Adds an AddNodePanel messaging story that drills into an empty category to render blocker/recovery messages.

Comment on lines 1778 to +1785
name: 'Inline Editing',
render: () => <InlineEditingStory />,
};

export const AlertsAndErrors: Story = {
name: 'Alerts and Errors',
render: () => <AlertsAndErrorsStory />,
};
@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core 9.0% 43.82 MB 57.31 MB ±0
@uipath/apollo-react 34.6% 0.0% (0/67) 7.27 MB 27.58 MB +207 B
@uipath/apollo-wind 40.1% 392.4 KB 2.55 MB −3 B
@uipath/ap-chat 85.8% 43.41 MB 55.85 MB ±0

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

boxShadow: '0 4px 12px rgba(0, 0, 0, 0.1)',
}}
>
<DocumentExtractionMessagePanel state={state} />

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we're more prescriptive about the content of htis panel

the way this is written, a consumer can place anything into the panel vs we could just provide "slots" e.g. errorMessage onPrimaryButtonClick etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:apollo-react size:XL 500-999 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants