[codex] Add AddNodePanel message type story#859
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
Pull request overview
Adds new Storybook coverage for canvas panel messaging/validation patterns to aid UX review, plus a small internal import-path adjustment.
Changes:
- Adds an “Add node panel message types” Storybook story that previews three Document extraction empty-state message variants side by side.
- Extends the NodePropertyPanel Storybook file with an “Alerts and Errors” story demonstrating tab-level counts, a summary list, and inline field validation treatment.
- Updates
HierarchicalCanvasto importBaseNodevia the direct module path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/apollo-react/src/canvas/components/NodePropertyPanel/NodePropertyPanel.stories.tsx | Adds an “Alerts and Errors” story and supporting UI helpers to showcase validation patterns. |
| packages/apollo-react/src/canvas/components/HierarchicalCanvas/HierarchicalCanvas.tsx | Adjusts BaseNode import path to a direct module import. |
| packages/apollo-react/src/canvas/components/AddNodePanel/AddNodePanel.stories.tsx | Adds an AddNodePanel messaging story that drills into an empty category to render blocker/recovery messages. |
| name: 'Inline Editing', | ||
| render: () => <InlineEditingStory />, | ||
| }; | ||
|
|
||
| export const AlertsAndErrors: Story = { | ||
| name: 'Alerts and Errors', | ||
| render: () => <AlertsAndErrorsStory />, | ||
| }; |
📊 Coverage + size by packagePer-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
"Coverage" is each package's own |
| boxShadow: '0 4px 12px rgba(0, 0, 0, 0.1)', | ||
| }} | ||
| > | ||
| <DocumentExtractionMessagePanel state={state} /> |
There was a problem hiding this comment.
ideally we're more prescriptive about the content of htis panel
the way this is written, a consumer can place anything into the panel vs we could just provide "slots" e.g. errorMessage onPrimaryButtonClick etc
Summary
UX Pattern
This story documents blocker and recovery messages inside the Add Node panel. Each state keeps the same panel shell and title area so reviewers can compare message tone, spacing, and next actions consistently.
Validation
AddNodePanel.stories.tsx.