Skip to content

fix(apollo-react): default add-node search placeholder to "Search nodes" [MST-11831]#880

Open
KodudulaAshishUiPath wants to merge 1 commit into
mainfrom
fix/MST-11831-add-node-search-placeholder
Open

fix(apollo-react): default add-node search placeholder to "Search nodes" [MST-11831]#880
KodudulaAshishUiPath wants to merge 1 commit into
mainfrom
fix/MST-11831-add-node-search-placeholder

Conversation

@KodudulaAshishUiPath

Copy link
Copy Markdown
Contributor

Summary

  • The add-node panel's search input showed a generic "Search" placeholder. Per the Flow building experience content audit, search placeholders should describe what will be searched.
  • AddNodePanel now defaults its search placeholder to "Search nodes" (new lingui message addNodePanel.searchNodes).
  • Both AddNodePanel and Toolbox expose an optional searchPlaceholder prop so hosts can pass scoped copy ("Search agents", "Search data nodes") per menu context.

Changes

  • Toolbox: new optional searchPlaceholder prop; default behavior unchanged (lingui toolbox.search = "Search"), so other Toolbox consumers (e.g. StageNode) are unaffected
  • AddNodePanel + AddNodePanel.types: pass-through prop, defaulting to "Search nodes"
  • src/canvas/locales/en.json: addNodePanel.searchNodes entry (English only; translated catalogs land via the usual translator flow)

Testing

  • Toolbox + AddNodePanel test suites pass (146 tests)
  • turbo run typecheck --filter=@uipath/apollo-react green; biome lint shows only pre-existing warnings
  • Note: pnpm run i18n:extract currently fails repo-wide on a pre-existing duplicate id in ap-chat (autopilot-chat.error.multiple-files has two different default texts) — the catalog entry was added by hand and verified with i18n:compile

Copilot AI review requested due to automatic review settings July 3, 2026 11:50
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-design 🟢 Ready Preview, Logs Jul 03, 2026, 04:54:47 AM
apollo-docs 🟢 Ready Preview, Logs Jul 03, 2026, 04:54:47 AM
apollo-landing 🟢 Ready Preview, Logs Jul 03, 2026, 04:54:47 AM
apollo-vertex 🟢 Ready Preview, Logs Jul 03, 2026, 04:54:47 AM

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Dependency License Review

  • 1945 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1715
ISC 89
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the canvas add-node search UX copy in @uipath/apollo-react so the placeholder describes what the user is searching, aligning with the referenced content audit guidance.

Changes:

  • Added a new Lingui message id for the add-node search placeholder and defaulted it to “Search nodes” in AddNodePanel.
  • Extended Toolbox with an optional searchPlaceholder prop (default remains the existing generic “Search”).
  • Plumbed the optional searchPlaceholder through AddNodePanel so hosts can override it with context-specific copy.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/apollo-react/src/canvas/locales/en.json Adds addNodePanel.searchNodes English catalog entry (“Search nodes”).
packages/apollo-react/src/canvas/components/Toolbox/Toolbox.tsx Introduces optional searchPlaceholder prop and applies it to the search input placeholder with a backwards-compatible default.
packages/apollo-react/src/canvas/components/AddNodePanel/AddNodePanel.types.ts Adds optional searchPlaceholder prop to AddNodePanelProps.
packages/apollo-react/src/canvas/components/AddNodePanel/AddNodePanel.tsx Defaults add-node placeholder to the new Lingui message (“Search nodes”) and passes through host override.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core 9.0% 43.82 MB 57.31 MB ±0
@uipath/apollo-react 34.5% 100.0% (3/3) 7.27 MB 27.60 MB +224 B
@uipath/apollo-wind 40.1% 392.5 KB 2.55 MB +1 B
@uipath/ap-chat 85.8% 43.41 MB 55.85 MB −10 B

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:apollo-react size:S 10-29 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants