test(troubleshoot): normalize task tags to sanctioned dimensions#1838
test(troubleshoot): normalize task tags to sanctioned dimensions#1838MarinRzv wants to merge 1 commit into
Conversation
Strip package/leaf tags that duplicate the directory path (word-activities, export-pdf, job-killed, exit-code-*, get-asset, ...) and non-vocab markers (faithful-replay, faulted-jobs, pending-job, healing-agent, licensing) from all troubleshoot scenarios. Keep only skill + tier + mode + lifecycle + product/domain tags from the closed vocabulary. Reconcile the orchestrator tag: keep it only where the failure is genuinely Orchestrator-scoped (products/orchestrator, cross-system); remove it from activity-package/runtime scenarios that merely investigate via 'uip or'. Broaden the orchestrator tag definition in CLAUDE.md to match actual usage.
|
Claude finished @MarinRzv's task in 3m 58s —— View job Coder-eval task lint (advisory)
Coder-eval task lint (advisory)182 task YAMLs modified (0 added); all changes are tags-only (single line per file). Verdict counts: 0 Critical, 0 High, 0 Medium, 0 Low, 182 OK. Rubric: .claude/commands/lint-task.md. This check is advisory and never blocks merge. Evidence of passing run❌ High — PR body does not claim the changed tasks have been run and passed. Since this PR only modifies the
Per-task lintAll 182 changed files modify only the Verdict: OK for all 182 files. Spot-checked groups (click to expand)
Within-PR duplicatesNot applicable — no new tasks added (all 182 are modifications). Note: tag consistency with updated CLAUDE.mdThe updated
The
These tasks' names start with Conclusion✅ All 182 changed tasks pass the rubric (tag-only edits, no test-design impact). One consistency note above (3 |
|
Claude finished @MarinRzv's task in 3m 8s —— View job PR Review: Normalize troubleshoot task tags
SummaryStrips non-vocabulary tags ( Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | OK | All changes are to tags: lines only — no frontmatter breakage |
| E2E Tests | OK | No test structure changes; only tag normalization |
| Skill Body | N/A | No skill SKILL.md changes |
| References & Assets | OK | CLAUDE.md tag definition update is correct and well-scoped |
| Repo Hygiene | OK | Changes scoped to troubleshoot test suite only; no secrets, no cross-skill impact |
Issues for Manual Review
- The
orchestratortag removal from activity-package tasks assumes those scenarios don't genuinely involve Orchestrator control-plane failures. The PR description and updated CLAUDE.md definition make a clear case, but domain experts may want to spot-check a few edge cases (e.g.,system-activities/getasset-*tasks that fail on Orchestrator asset/folder resolution — are those activity-package or Orchestrator-scoped?).
Conclusion
Clean tag normalization PR. The non-vocab tag removal is consistent and correct across all 182 files. The CLAUDE.md orchestrator definition update is well-reasoned and matches the actual tag application. One minor ordering inconsistency in 2 files (Low). Recommend approving with the optional tag-ordering fix.
Strip package/leaf tags that duplicate the directory path (word-activities, export-pdf, job-killed, exit-code-*, get-asset, ...) and non-vocab markers (faithful-replay, faulted-jobs, pending-job, healing-agent, licensing) from all troubleshoot scenarios. Keep only skill + tier + mode + lifecycle + product/domain tags from the closed vocabulary.
Reconcile the orchestrator tag: keep it only where the failure is genuinely Orchestrator-scoped (products/orchestrator, cross-system); remove it from activity-package/runtime scenarios that merely investigate via 'uip or'. Broaden the orchestrator tag definition in CLAUDE.md to match actual usage.