feat(troubleshoot): language-invariant routing signatures + localization lint warning#1842
Draft
dmorosanu wants to merge 1 commit into
Draft
feat(troubleshoot): language-invariant routing signatures + localization lint warning#1842dmorosanu wants to merge 1 commit into
dmorosanu wants to merge 1 commit into
Conversation
…nments + lint warning
Contributor
Author
|
Validation complete (local, judge-graded, skill loaded from this branch): 8/8 SUCCESS, all at 1.000, single iteration each (one scenario took a second iteration by simulator flow, still 1.000).
Selection rationale: these route through playbooks in the message-only (localization-exposed) class that this PR hardens — they are the first to break if the invariant-first prioritization or the added signatures steered routing wrong. No regression; the added signatures coexist with the message routing on English fixtures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stacked on #1820. Hardens signature-index routing for clients whose robot hosts run non-English system languages (.NET framework and Office/COM error text localizes with the host language; the index stores canonical English).
Two parts:
messagefragments. Every addition is a signal the playbook's body already documents verbatim — exception classes, HTTP statuses, Google/Graph error reason codes, HRESULTs, Healing Agent operation codes/allowance fields — promoted intosignatures:with discriminating notes wherever a value is claimed by more than one playbook. No playbook bodies changed; no values invented (files whose bodies document nothing invariant were deliberately left untouched).build-signature-index.py(INVARIANT_KINDS): a signature-bearing playbook with no invariant-kind signature is flagged — warning only, never affects the exit code. Baseline drops 68 → 38 warnings; the remaining 38 are genuinely message-only per body content and stay covered at runtime by SKILL.md's localized-text rule (route on invariant signals first; translate non-English messages to canonical English before grepping — added on refactor(troubleshoot): tiered signature-index investigator (v2 architecture) #1820).Index regenerated: 215 playbooks, 674 signatures (+43), 22 silent. Manifest-command verifier and index freshness pass.
Language-invariance model
exception,error-code,error-code-prefix,http-status,message-keymessagestateValidation
The 8 scenarios whose playbooks sit in the affected class (no-host-pending, getasset-network-connectivity, getasset-per-robot-no-value, healing-agent-no-license, python-loadscript-engine-init, o365-createfolder-invalid-path, invokevba-trust-access, plus no-healing-agent whose fixture evidence contains non-English UI text) are running against this branch — results will be posted as a comment.