fix: remove ConfigurableRuntimeFactory, read settings from schema.metadata #1164
+516
−836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adata Remove the incorrect implementation that wrapped the factory and created temporary files. Instead, read agent settings from schema.metadata which is populated by the low-code agents runtime. - Remove ConfigurableRuntimeFactory class and tests - Update _get_agent_model() to read from schema.metadata["settings"]["model"] - Keep fallback to protocol for backwards compatibility - Update uipath-runtime dependency to >=0.3.4 (includes metadata field) - Remove temp file cleanup from __aexit__ PR #1053 introduced a design that broke separation of concerns: - Wrapped the factory unnecessarily - Deserialized agent.json in the CLI layer - Created temporary modified JSON files - Required cleanup of temp files The correct design (per @cristipufu feedback): - Low-code repo populates schema.metadata with settings - CLI reads settings from schema.metadata - No temp files, no factory wrapper, no JSON deserialization in CLI 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
test:uipath-langchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the incorrect implementation that wrapped the factory and created temporary files. Instead, read agent settings from schema.metadata which is populated by the low-code agents runtime.
PR #1053 introduced a design that broke separation of concerns:
The correct design (per @cristipufu feedback):
🤖 Generated with Claude Code