Introduce bridging heuristic(s)#2286
Merged
Merged
Conversation
Apply two different behaviours in the case where the bridge area is completely supported and when it is not. If the area is completely supported from all sides calculate the minimum oriented bounding box. The orientation of this bounding box is then the angle for the bridging. For the case where the bridge area is not completely supported the old strategy is used where each angle between 0 and 180 is considered, and the best evaluated direction is used. NP-12975
Remco Burema (rburema)
approved these changes
Feb 18, 2026
Remco Burema (rburema)
left a comment
Remco Burema (rburema)
left a comment
Member
There was a problem hiding this comment.
Looks good! Please have a look at my comments anyway.
(Haven't done the component test yet, but I don't expect big problems there either.)
Comment on lines
+230
to
+233
| for (auto iterator = shape[0].beginSegments(); iterator != shape[0].endSegments(); ++iterator) | ||
| { | ||
| const Point2LL& p1 = (*iterator).start; | ||
| const Point2LL& p2 = (*iterator).end; |
There was a problem hiding this comment.
Side-note: I think I'd prefer it if we could use ranges (or just the for-each-type loop) for these kinds of things, but that's outside of the scope of this ticket.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apply two different behaviours in the case where the bridge area is completely supported and when it is not.
If the area is completely supported from all sides calculate the minimum oriented bounding box. The orientation of this bounding box is then the angle for the bridging.
For the case where the bridge area is not completely supported the old strategy is used where each angle between$0$ and $180$ is considered, and the best evaluated direction is used.
CURA-12975