[CURA-13248] Fix quoted extruder capture in template regex#2342
Merged
Conversation
Updated the G-code template resolver regex so the optional `extruder_nr` group no longer matches single or double quotes. This tightens placeholder parsing and prevents invalid quoted values from being treated as extruder identifiers. This allows for comparisons such as if "value in list" which currently results in the last list item being associated as extruder_nr
HellAholic
changed the title
HellAholic
marked this pull request as ready for review
June 29, 2026 12:29
Contributor
Test Results31 tests 31 ✅ 5s ⏱️ Results for commit d45dcfc. ♻️ This comment has been updated with latest results. |
The 1.2.1 package provides "str" in "str" check. see: Ultimaker/CuraFormulaeEngine#6
Casper Lamboo (casperlamboo)
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the G-code template resolver regex so the optional
extruder_nrgroup no longer matches single or double quotes. This tightens placeholder parsing and prevents invalid quoted values from being treated as extruder identifiers. This allows for comparisons such as if "value in list" which currently results in the last list item being associated as extruder_nrCURA-13248