Apply fuzzy skin to the spiral wall when spiralize is enabled#2348
Open
kvanonavk (kvanonavk) wants to merge 1 commit into
Open
Apply fuzzy skin to the spiral wall when spiralize is enabled#2348kvanonavk (kvanonavk) wants to merge 1 commit into
kvanonavk (kvanonavk) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes fuzzy skin not being applied when Spiralize Outer Contour is enabled, a regression introduced with the variable-width wall toolpaths (Arachne) in Cura 5.0.
FffPolygonGenerator::processFuzzyWalls()only processespart.wall_toolpaths, but in spiralize mode the wall is stored as plain polygons inpart.spiral_wall, so fuzzy skin was only visible on the initial bottom layers (the only layers that get wall toolpaths). Before 5.0 the spiral wall was handled explicitly (spiralize ? part.spiral_wall : part.insets[0]).This restores that behavior by applying the same fuzzing to the spiral wall polygons, including the "Fuzzy Skin Outside Only" hole check and the first-layer brim exception.
Fixes Ultimaker/Cura#12850
Type of change
How Has This Been Tested?
tests/integration/resources/cylinder1000.stlwithmagic_spiralize=trueandmagic_fuzzy_skin_enabled=true(otherwise default fdmprinter settings), comparing the radial deviation of the wall from the layer centroid per layer:Test Configuration:
IMPORTANT
The code was generated using Claude's Fable model. I was annoyed by this bug for quite a while (the issue on Github is almost 4 years old) so I decided to give it a go using Fable. Looks fine and works as expected but I'd really appreciate if someone could take a look at it and verify that it can be merged, thank you!