CURA-13249 Merge header with first GCode part#2350
Open
Erwan MATHIEU (wawanbreton) wants to merge 1 commit into
Open
CURA-13249 Merge header with first GCode part#2350Erwan MATHIEU (wawanbreton) wants to merge 1 commit into
Erwan MATHIEU (wawanbreton) wants to merge 1 commit into
Conversation
Contributor
Casper Lamboo (casperlamboo)
approved these changes
Jul 17, 2026
Casper Lamboo (casperlamboo)
left a comment
Contributor
There was a problem hiding this comment.
Don't fully understand why this is needed, but code looks good
Contributor
Author
The front-end saves the GCode parts in a list, and the post-processing plugins expect this list to be in a certain order, with the first elements containing specific parts, namely the header, init gcode and start gcode. With the new structure we had an intermediate part inserted, so scripts were confused. Other option would be to change the post-processing scripts, but that would require more effort, and possible be annoying because the start GCode is optional. |
Base automatically changed from
CURA-13226_slice-speed-benchmark-tooling
to
main
July 20, 2026 11:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of sending the GCode header as a separate part, we now send it with the very first part of the actual GCode commands, so that it matches the previous behavior and should allow the post-processing scripts to work without having to fix them all.
Since I am not very familiar with the post-processing scripts, I assume this is the correct fix but the result looks a bit weird to me, so please double-check.
CURA-13249