Skip to content

CURA-13249 Merge header with first GCode part#2350

Open
Erwan MATHIEU (wawanbreton) wants to merge 1 commit into
mainfrom
CURA-13249_fix_array_data_structure
Open

CURA-13249 Merge header with first GCode part#2350
Erwan MATHIEU (wawanbreton) wants to merge 1 commit into
mainfrom
CURA-13249_fix_array_data_structure

Conversation

@wawanbreton

Copy link
Copy Markdown
Contributor

Instead of sending the GCode header as a separate part, we now send it with the very first part of the actual GCode commands, so that it matches the previous behavior and should allow the post-processing scripts to work without having to fix them all.
Since I am not very familiar with the post-processing scripts, I assume this is the correct fix but the result looks a bit weird to me, so please double-check.

⚠️ This PR merges to CURA-13226_slice-speed-benchmark-tooling because it also changes the behavior of the initial GCode sending

CURA-13249

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

31 tests  ±0   31 ✅ ±0   5s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 666e6fa. ± Comparison against base commit 5a53fc2.

@wawanbreton Erwan MATHIEU (wawanbreton) changed the title Merge header with first GCode part CURA-13249 Merge header with first GCode part Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't fully understand why this is needed, but code looks good

@wawanbreton

Copy link
Copy Markdown
Contributor Author

Don't fully understand why this is needed, but code looks good

The front-end saves the GCode parts in a list, and the post-processing plugins expect this list to be in a certain order, with the first elements containing specific parts, namely the header, init gcode and start gcode. With the new structure we had an intermediate part inserted, so scripts were confused.

Other option would be to change the post-processing scripts, but that would require more effort, and possible be annoying because the start GCode is optional.

Base automatically changed from CURA-13226_slice-speed-benchmark-tooling to main July 20, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants