Skip to content

CURA-13226 Fix binding according to library changes #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Erwan MATHIEU (wawanbreton) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CURA-13226 Fix binding according to library changes #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6020994
Fix binding according to library changes
wawanbreton Jul 3, 2026
5f372b8
Bump version
wawanbreton Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions conandata.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
version: "5.11.1-alpha.0"
version: "5.12.0"
requirements:
- "savitar/5.11.0-alpha.0"
- "savitar/5.12.0"
2 changes: 1 addition & 1 deletion python/MeshData.sip
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public:
MeshData();
virtual ~MeshData();
bytearray getVerticesAsBytes();
bytearray getFacesAsBytes();
bytearray getFacesAsBytes() const;

bytearray getFlatVerticesAsBytes();

Expand Down
4 changes: 2 additions & 2 deletions python/Scene.sip
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public:
Scene();
virtual ~Scene();

std::vector<SceneNode*> getSceneNodes();
const std::vector<SceneNode*>& getSceneNodes() const;
std::vector<SceneNode*> getAllSceneNodes();

void addSceneNode(SceneNode* node /Transfer/);
Expand All @@ -21,7 +21,7 @@ public:
void setMetaDataEntry(const std::string& key, const std::string& value, const std::string& type);
void setMetaDataEntry(const std::string& key, const std::string& value, const std::string& type, const bool preserve);

std::string getUnit();
const std::string& getUnit() const;
void setUnit(std::string unit);
};

10 changes: 5 additions & 5 deletions python/SceneNode.sip
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ public:
SceneNode();
virtual ~SceneNode();

MeshData& getMeshData();
const MeshData& getMeshData() const;

std::vector<SceneNode*> getChildren();
const std::vector<SceneNode*>& getChildren() const;

std::string getTransformation();
void setTransformation(std::string);
const std::string& getTransformation() const;
void setTransformation(const std::string&);

std::string getName();
const std::string& getName() const;
void setName(std::string name);

int getId();
Expand Down