Secondary Role: Fixed a bug where positive safety margin did not work#1487
Merged
kareltucek merged 1 commit intoUltimateHackingKeyboard:masterfrom Feb 12, 2026
Conversation
firngrod
commented
Feb 12, 2026
|
|
||
| // now we want to trigger secondary, but are we allowed? | ||
| // handle safety margin part 2: wait for the safety margin? | ||
| const bool safetyWaitForRelease = safetyBlockSecondary && dualRoleRelease == NULL; |
Contributor
Author
There was a problem hiding this comment.
Actually, the check for no dual role key release should be redundant here. If we had one, we would have reached line 176
Collaborator
There was a problem hiding this comment.
Code robustness and readability say that it is fine and probably preferred :-).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1486