This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Conversation
Closed
zbruick
suggested changes
Jul 31, 2019
Contributor
zbruick
left a comment
zbruick
left a comment
There was a problem hiding this comment.
Looks good overall - mainly minor cleanups to docstrings and error messages.
Contributor
|
Some of these commits can still be squashed down it looks like |
zbruick
approved these changes
Jul 31, 2019
More changes to the spacing and syntax. Changing syntax. Another new syntax change to please Travis. Adding one blank line. Changing a dictionary call.
Deleting images.json and BM.jpeg images because it was not conducive to actual example, now Hurricanes are plotted on a basic Cartopy image Deleting Blue Marble feature of HurricaneTracker.py
…rricane Center data in siphon Fixing a dummy call to siphon Added a new play button widget and changed docstrings to match Pep8 Hurricane Tracker, using nhc from siphon.simplewebservice
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.