This repository was archived by the owner on Jan 9, 2020. It is now read-only.
Open
Conversation
Author
|
Pinging this PR now that siphon/#272 has been merged. |
Contributor
|
Yes, this deserves reviewing now, but it won't pass Travis until Siphon gets a new release. |
zbruick
suggested changes
Aug 21, 2019
Contributor
zbruick
left a comment
zbruick
left a comment
There was a problem hiding this comment.
Overall, this looks really good. While it will be one of our more complex examples, I'm not sure how to reduce it down any to still get what we want. The only thing I'm curious about adding is a colorbar for the GLM data. If that's not too much to ask, and doesn't make the plot too busy, I think that could be useful.
Co-Authored-By: Zach Bruick <zachary.bruick@valpo.edu>
zbruick
approved these changes
Sep 3, 2019
Contributor
zbruick
left a comment
zbruick
left a comment
There was a problem hiding this comment.
This looks good, but we'll have to sit on it until the next siphon release for CI to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gridded GLM imagery are now available on threads-test. This example adapts the water vapor + aircraft example to overlay GLM data on ABI imagery. Requires Unidata/siphon/#272 for parsing times.