Improve SBOM graph completeness and VEX credibility gates#1555
Open
ManuelSalcedo2770 wants to merge 1 commit into
Open
Improve SBOM graph completeness and VEX credibility gates#1555ManuelSalcedo2770 wants to merge 1 commit into
ManuelSalcedo2770 wants to merge 1 commit into
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #1535
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name: sbom-analysis
Skill path:
skills/vuln-management/sbom-analysis/What Was Wrong
Issue #1535 documented that
sbom-analysiscould rate an SBOM as complete even when transitive dependencies were only flat-listed, and that the VEX output did not distinguish vendor-attestedNot Affectedstatements from consumer-verified evidence. It also mentioned SBOM freshness/trustworthiness and staleUnder InvestigationVEX entries as pitfalls, but the skill did not require those fields in the structured output.What This PR Fixes
graph_completenessdimension to the NTIA completeness assessment, with Complete Graph / Partial Graph / Flat List / Missing Graph ratings.consumer_verified,third_party_verified,vendor_attested, andnot_verifiedstatuses.Evidence
Before (skill misses this / false positive on this):
After (now correctly handled):
Test Cases Added/Updated
tests/vulnerable/)tests/benign/)Added fixtures:
flat-transitive-cyclonedx.jsondemonstrates a flat-list SBOM that should not be treated as graph-complete.vendor-attested-stale-vex.jsondemonstrates vendor-attestedNot Affectedplus staleUnder InvestigationVEX states.traceable-cyclonedx-with-provenance.jsondemonstrates a benign traceable dependency graph with generation/provenance evidence.consumer-verified-vex.jsondemonstrates a benign VEX entry with consumer verification evidence.Validation
git diff --checkSKILL.mdgraph_completeness, VEX credibility, stale investigation, freshness, provenance, and trustworthiness.github/workflows/lint-skills.yml.github/workflows/injection-scan.ymlBounty Tier
Bounty Info
Closes #1535