Add secure-code-review SSRF URL validation gates#1704
Open
yanziwei wants to merge 1 commit into
Open
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill
skills/appsec/secure-code-review/SKILL.mdCloses #1702.
What Was Wrong
secure-code-reviewincluded a basic SSRF example and checklist item, but did not require evidence for common bypass paths: URL parser differentials, redirects without revalidation, DNS rebinding, alternate IP encodings, IPv6/link-local/private ranges, or cloud metadata endpoint denial.What This PR Fixes
SSRF URL Canonicalization and Redirect Reviewunder Step 8.SCR-SSRF-01throughSCR-SSRF-07for parser differentials, redirect gaps, DNS rebinding, weak IP filtering, metadata endpoints, alternate IP encodings, and protocol confusion.SSRF URL Fetch Reviewoutput table.Test Cases
SCR-SSRF-01.SCR-SSRF-02andSCR-SSRF-05.SCR-SSRF-03.SCR-SSRF-04orSCR-SSRF-06.Validation
git diff --checkskills/appsec/secure-code-review/SKILL.md.SSRF URL Canonicalization and Redirect Review,SCR-SSRF-01,SCR-SSRF-07,SSRF URL Fetch Review, andTreating SSRF as a single allowlist check.Bounty Tier
Moderate ($100) - adds focused code-review evidence gates for SSRF false negatives and bypass patterns.
Bounty Info
1005150221@qq.com