Add CIS AWS benchmark version preflight to aws-review#1710
Open
yui-stingray wants to merge 1 commit into
Open
Conversation
5191cdf to
1fd4369
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name: aws-review
Skill path:
skills/cloud/aws-review/What Was Wrong
The aws-review skill was fixed to CIS AWS Foundations Benchmark v3.0.0 in several places. That made current posture reports easy to overstate because the output format used v3.0.0 assumptions such as fixed section denominators and did not require benchmark version, Security Hub standard, or support-status evidence before scoring.
Addresses #213 as a scoped preflight/output improvement. This PR does not attempt a full CIS AWS v5.0.0 control-map rewrite.
What This PR Fixes
Evidence
Before (skill could overstate current coverage):
After (now version-aware before scoring):
Reference sources used:
Test Cases Added/Updated
skills/cloud/aws-review/tests/cis-benchmark-version-preflight.mdtests/vulnerable/) - N/A for this reporting/preflight guardrailtests/benign/) - N/A for this reporting/preflight guardrailValidation run:
Note: upstream GitHub Actions runs are currently waiting for maintainer approval for this fork PR (
action_required) before jobs are created.Bounty Tier
Bounty Info