Skip to content

Comments

UUM-134930: [2.10.x] Converted remaining references from instanceID to entityID.#1100

Merged
sim-bz merged 3 commits intorelease/2.10from
2.10/uum-134930
Feb 23, 2026
Merged

UUM-134930: [2.10.x] Converted remaining references from instanceID to entityID.#1100
sim-bz merged 3 commits intorelease/2.10from
2.10/uum-134930

Conversation

@sim-bz
Copy link
Collaborator

@sim-bz sim-bz commented Feb 23, 2026

Purpose of this PR

https://jira.unity3d.com/browse/UUM-134930

Testing status

[Explanation of what’s tested, how tested and existing or new automation tests. Can include manual testing by self and/or QA. Specify test plans. Rarely acceptable to have no testing.]

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

[Overview of how documentation is affected by this change. If there is no effect on documentation, explain why. Otherwise, state which sections are changed and why.]

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

[Overall product level assessment of risk of change. Need technical risk & halo effect.]

Comments to reviewers

[Info per person for what to focus on, or historical info to understand who have previously reviewed and coverage. Help them get context.]

Package version

[Justification for updating either the patch, minor, or major version according to the semantic versioning rules]

  • Updated package version

@u-pr
Copy link
Contributor

u-pr bot commented Feb 23, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

UUM-134930 - PR Code Verified

Compliant requirements:

  • Replaced EditorApplication.hierarchyWindowItemOnGUI with EditorApplication.hierarchyWindowItemByEntityIdOnGUI using #if UNITY_6000_4_OR_NEWER.
  • Replaced EditorUtility.InstanceIDToObject(int) with EditorUtility.EntityIdToObject using #if UNITY_6000_4_OR_NEWER.
  • Method OnHierarchyGUI updated to accept EntityId instead of int instanceID for versions 6000.4 and newer.

Requires further human verification:

  • Verify that UNITY_6000_4_OR_NEWER is the correct preprocessor define corresponding to Unity 6.4 where these APIs became available and implicitly casting was obsoleted.
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

The PR is very small, straightforward, and clearly addresses the API deprecation issue using standard preprocessor directives.
🏅 Score: 100

The code perfectly addresses the deprecation warnings using standard C# preprocessor blocks, correctly maintaining backwards compatibility for earlier Unity versions.
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected
  • Update review

🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr

@u-pr
Copy link
Contributor

u-pr bot commented Feb 23, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@sim-bz sim-bz changed the title [2.10.x] Converted remaining references from instanceID to entityID. UUM-134930 [2.10.x] Converted remaining references from instanceID to entityID. Feb 23, 2026
@sim-bz sim-bz changed the title UUM-134930 [2.10.x] Converted remaining references from instanceID to entityID. UUM-134930: [2.10.x] Converted remaining references from instanceID to entityID. Feb 23, 2026
@sim-bz sim-bz merged commit 935f775 into release/2.10 Feb 23, 2026
79 of 80 checks passed
@sim-bz sim-bz deleted the 2.10/uum-134930 branch February 23, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants