UnityAds adapter: Migrate adapter to use new apis#28
Open
AnwarissaAsbah wants to merge 5 commits into
Open
Conversation
vita-unity
reviewed
May 20, 2026
| * Mobile Ads SDK and Unity Ads SDK. | ||
| */ | ||
| @Keep | ||
| @OptIn(markerClass = UnityAdsExperimental.class) |
There was a problem hiding this comment.
I don't think you need those for 4.19.0. Release/next already has code without it. cc @lmoreault
Keep UnityAdapter new API implementation (InterstitialAd, LoadConfiguration, ShowConfiguration) with @OptIn(UnityAdsExperimental) over main's empty stub, as this branch is specifically migrating to Unity Ads 4.18.0 APIs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| if (token == null) { | ||
| token = ""; | ||
| } | ||
| signalCallbacks.onSuccess(token); |
There was a problem hiding this comment.
Lets please change this to a signalCallbacks.onFailure(
| if (token == null) { | ||
| token = ""; | ||
| } | ||
| signalCallbacks.onSuccess(token); |
There was a problem hiding this comment.
Lets please change this to a signalCallbacks.onFailure(
| if (token == null) { | ||
| token = ""; | ||
| } | ||
| signalCallbacks.onSuccess(token); |
There was a problem hiding this comment.
Event from token is empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate adapter to use new apis.