Changed ServiceGroup: from GenerationType.AUTO to GenerationType.IDEN…#329
Open
stanleykc wants to merge 1 commit into
Open
Changed ServiceGroup: from GenerationType.AUTO to GenerationType.IDEN…#329stanleykc wants to merge 1 commit into
stanleykc wants to merge 1 commit into
Conversation
…TITY. This makes ServiceGroup consistent with all other entities in the codebase and uses MySQL's native AUTO_INCREMENT instead of the hibernate_sequence table, which prevents the duplicate key errors when creating new service groups. Signed-off-by: Kevin Stanley <stanleyk@objectcomputing.com>
jjelliott
reviewed
Jan 9, 2026
jjelliott
left a comment
jjelliott
left a comment
Contributor
There was a problem hiding this comment.
Does this need an accompanying schema update?
mvolkmann
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the inconsistent ID generation issue.
This issue was uncovered when creating a new service group using the existing Service Request Definition Editor. It is a backend issue that will impact a new editor as well.
This makes ServiceGroup consistent with all other entities in the codebase and uses MySQL's native AUTO_INCREMENT instead of the hibernate_sequence table, which prevents the duplicate key errors when creating new service groups.
Fixes #325
Changes