Skip to content

fix: resolve critical safety and concurrency issues#4

Open
zbzhu99 wants to merge 1 commit into
mainfrom
claude/audit-bugs-performance-Ml01N
Open

fix: resolve critical safety and concurrency issues#4
zbzhu99 wants to merge 1 commit into
mainfrom
claude/audit-bugs-performance-Ml01N

Conversation

@zbzhu99

@zbzhu99 zbzhu99 commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Safety fixes:

  • Enable Gello joint position and velocity safety clipping (was disabled)
  • Fix Franka FR3 clear_error() referencing wrong object (robot_c -> robot)
  • Fix Franka disconnect() missing gripper null check before deletion
  • Fix UR5 clear_error() missing null check for robot_c
  • Fix UR5 reset_to_init/move_to_joint_positions missing init_qvel default
  • Fix UR5 gripper null check in reset_to_init()

Concurrency fixes:

  • Add thread-safe locks to SharedMemoryQueue put/get/get_k/get_all methods
  • Add thread-safe lock to SharedMemoryRingBuffer put method
  • Fix timestamp consistency in ring buffer (use same time value)

Stability fixes:

  • Add 5-second timeout to state_thread.join() to prevent process hang
  • Replace bare except with specific Exception types in xarm6 and ur5

Safety fixes:
- Enable Gello joint position and velocity safety clipping (was disabled)
- Fix Franka FR3 clear_error() referencing wrong object (robot_c -> robot)
- Fix Franka disconnect() missing gripper null check before deletion
- Fix UR5 clear_error() missing null check for robot_c
- Fix UR5 reset_to_init/move_to_joint_positions missing init_qvel default
- Fix UR5 gripper null check in reset_to_init()

Concurrency fixes:
- Add thread-safe locks to SharedMemoryQueue put/get/get_k/get_all methods
- Add thread-safe lock to SharedMemoryRingBuffer put method
- Fix timestamp consistency in ring buffer (use same time value)

Stability fixes:
- Add 5-second timeout to state_thread.join() to prevent process hang
- Replace bare except with specific Exception types in xarm6 and ur5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants