fix: resolve critical safety and concurrency issues#4
Open
zbzhu99 wants to merge 1 commit into
Open
Conversation
Safety fixes: - Enable Gello joint position and velocity safety clipping (was disabled) - Fix Franka FR3 clear_error() referencing wrong object (robot_c -> robot) - Fix Franka disconnect() missing gripper null check before deletion - Fix UR5 clear_error() missing null check for robot_c - Fix UR5 reset_to_init/move_to_joint_positions missing init_qvel default - Fix UR5 gripper null check in reset_to_init() Concurrency fixes: - Add thread-safe locks to SharedMemoryQueue put/get/get_k/get_all methods - Add thread-safe lock to SharedMemoryRingBuffer put method - Fix timestamp consistency in ring buffer (use same time value) Stability fixes: - Add 5-second timeout to state_thread.join() to prevent process hang - Replace bare except with specific Exception types in xarm6 and ur5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safety fixes:
Concurrency fixes:
Stability fixes: