Don't escape HTML in panel labels#187
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
=========================================
Coverage 60.78% 60.78%
Complexity 503 503
=========================================
Files 36 36
Lines 1525 1525
=========================================
Hits 927 927
Misses 598 598 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the PR! |
|
Of course! 🙂 |
I found that panel tab labels are HTML-escaped because double braces are used instead of triple braces.
An example of this occurs on the HAPPY HAPPY article from TWICEpedia on wiki.gg, where the tabs under "Song chronology" that have
&are escaped to show&. Another example is on the STRATEGY article, where#generates a list, which is rendered as<ol><li>...</li></ol>(solved with<nowiki />, but ideally the HTML should not be escaped).#115 seems to be related to this.