fix(pdf) set initial pdf scale to fit to available content height#806
Open
Gee-Bee wants to merge 3 commits intoUniversalViewer:masterfrom
Open
fix(pdf) set initial pdf scale to fit to available content height#806Gee-Bee wants to merge 3 commits intoUniversalViewer:masterfrom
Gee-Bee wants to merge 3 commits intoUniversalViewer:masterfrom
Conversation
…niversalViewer#742)" This reverts commit 67167e4. Setting canvas height with css makes text in pdf blurry. See [issue UniversalViewer#805](UniversalViewer#805)
fix UniversalViewer#805 fix UniversalViewer#622 Background: In 3.1.1 we gained possibility to zoom in and out pdf 🎆 UniversalViewer@888c4df The initial scale was set to 0.7 which in some cases made pdf smaller than available content area, in other pdf was bigger. To address this issue pull UniversalViewer#742 was made, in which the canvas was resized to available content height. Pdf was still rendered at 0.7 scale resulting in blurry text. This is another approach, which set the scale given the pdf page height and available content size prior to rendering.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mnemosceneteam/universalviewer/CmCwZAmwM1we679eW7vDwnBLTP7v [Deployment for 9ca36c9 failed] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #805
fix #622
Set initial pdf scale to fit to available content height.
Background:
In 3.1.1 we gained possibility to zoom in and out pdf 🎆
888c4df
The initial scale was set to 0.7 which in some cases made pdf smaller than available content area, in other pdf was bigger.
To address this issue pull #742 was made, in which the canvas was resized to available content height. However, pdf was still rendered at 0.7 scale resulting in blurry text.
This is another approach, which set the scale given the pdf page height and available content size prior to rendering. As a result the text in rendered pdf is sharp as it should be (before/after images in #805 ).