Open
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
demiankatz
reviewed
Mar 19, 2024
src/content-handlers/iiif/modules/uv-contentleftpanel-module/ContentLeftPanel.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Thanks, @nicolasfranck! I think the questions we now need to answer (which might require input from others) are whether there are other situations where we should invalidate the cache, and whether this replaces the existing config setting, or if it should perhaps be incorporated with it (e.g. if the thumbnail cache invalidation setting is disabled, should that prevent us from adding the extra parameter to thumbs?). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what you did:
?t=<timestamp>to the thumbnail uri, and I know that some people use query parameters in their iiif image api url's (because directly passed to an iipsrv). e.g. https://myhost/?IIIF=?t=timestamp